Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_hid: make stack size adjustable using Kconfig (IDFGH-3889) #5788

Closed
wants to merge 3 commits into from

Conversation

v1993
Copy link
Contributor

@v1993 v1993 commented Aug 25, 2020

This allows users to specify stack size for HID application callbacks. Default value is based on one that previously was hardcoded.

Note: it is possible that default value is too small for esp_hid_host example. I can't test it right now, but it is worth double checking.

@github-actions github-actions bot changed the title esp_hid: make stack size adjustable using Kconfig esp_hid: make stack size adjustable using Kconfig (IDFGH-3889) Aug 25, 2020
@me-no-dev
Copy link
Member

Could you please change it to HID_EVENT_TASK_STACK_SIZE?

@v1993
Copy link
Contributor Author

v1993 commented Aug 25, 2020

@me-no-dev No problem, but FYI I've based this naming off Bluetooth's BT_BTC_TASK_STACK_SIZE option.

@me-no-dev
Copy link
Member

Thanks @v1993 :)

@igrr
Copy link
Member

igrr commented May 17, 2021

@v1993 sorry that it took so long to handle this. We have merged #6385 which is very similar to your change, but makes run-time configuration of the stack size possible, rather than keeping it compile-time only. It also fixes the "default value too small" issue you have mentioned.

@igrr igrr closed this May 17, 2021
@espressif-bot espressif-bot added Resolution: Won't Do This will not be worked on Status: Done Issue is done internally labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants