Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Matter): New Matter Endpoint - Dimmable Light #10543

Merged
merged 17 commits into from
Nov 5, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Oct 29, 2024

Description of Change

Organizes the source code folder creating a folder called src/MatterEndpoints/
Adds a new Matter Endpoint: Dimmable Light, with example.
Ajusts the log level of main Matter Attribute processing callback.
Adds license information to the code.

Tests scenarios

ESP32C6 and ESP32S2 using the provided example.

Related links

Related to #7432

@SuGlider SuGlider added this to the 3.1.0-RC2 milestone Oct 29, 2024
@SuGlider SuGlider self-assigned this Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(matter): commentaries and code improvement. update() and callbacks added.":
    • summary should not end with a period (full stop)

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 17 commits (simplifying branch history).
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6e87b0d

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterCommissionTest----------
Matter/examples/MatterComposedLights----------
Matter/examples/MatterDimmableLight----------
Matter/examples/MatterOnOffLight----------

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Test Results

 62 files   62 suites   7m 27s ⏱️
 22 tests  21 ✅ 0 💤 1 ❌
144 runs  143 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 6e87b0d.

♻️ This comment has been updated with latest results.

@SuGlider SuGlider requested a review from lucasssvaz October 30, 2024 18:16
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with HomeAssistant running on VM.

@SuGlider SuGlider requested a review from me-no-dev October 31, 2024 13:36
@VojtechBartoska VojtechBartoska changed the title New Matter Endpoint: Dimmable Light feat(Matter): New Matter Endpoint - Dimmable Light Nov 4, 2024
@VojtechBartoska VojtechBartoska modified the milestones: 3.1.0-RC2, 3.1.0 Nov 4, 2024
@me-no-dev
Copy link
Member

Please include all endpoint headers into Matter.h so that only that header needs to be included by the users. Otherwise LGTM

@SuGlider
Copy link
Collaborator Author

SuGlider commented Nov 5, 2024

Please include all endpoint headers into Matter.h so that only that header needs to be included by the users. Otherwise LGTM

@me-no-dev - Done.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Nov 5, 2024
@me-no-dev me-no-dev merged commit 69825a9 into espressif:release/v3.1.x Nov 5, 2024
40 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

5 participants