Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying export file via ESPUP_EXPORT_FILE #403

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Allow specifying export file via ESPUP_EXPORT_FILE #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e92f0
Allow specifying export file via ESPUP_EXPORT_FILE
sirhcel Dec 11, 2023
04c3939
Add CHANGELOG.md entry for ESPUP_EXPORT_FILE
sirhcel Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Added support for specifying the location of the export file via `ESPUP_EXPORT_FILE` (#403)

### Fixed

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ rust-version = "1.70"

[dependencies]
async-trait = "0.1.74"
clap = { version = "4.4.11", features = ["derive"] }
clap = { version = "4.4.11", features = ["derive", "env"] }
clap_complete = "4.4.4"
console = "0.15.7"
directories = "5.0.1"
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ Options:
-f, --export-file <EXPORT_FILE>
Relative or full path for the export file that will be generated. If no path is provided, the file will be generated under home directory (https://docs.rs/dirs/latest/dirs/fn.home_dir.html)

[env: ESPUP_EXPORT_FILE=]

-e, --extended-llvm
Extends the LLVM installation.

Expand Down Expand Up @@ -209,6 +211,8 @@ Options:
-f, --export-file <EXPORT_FILE>
Relative or full path for the export file that will be generated. If no path is provided, the file will be generated under home directory (https://docs.rs/dirs/latest/dirs/fn.home_dir.html)

[env: ESPUP_EXPORT_FILE=]

-e, --extended-llvm
Extends the LLVM installation.

Expand Down
2 changes: 1 addition & 1 deletion src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pub struct InstallOpts {
#[arg(short = 'r', long)]
pub esp_riscv_gcc: bool,
/// Relative or full path for the export file that will be generated. If no path is provided, the file will be generated under home directory (https://docs.rs/dirs/latest/dirs/fn.home_dir.html).
#[arg(short = 'f', long)]
#[arg(short = 'f', long, env = "ESPUP_EXPORT_FILE")]
pub export_file: Option<PathBuf>,
/// Extends the LLVM installation.
///
Expand Down