Allow specifying export file via ESPUP_EXPORT_FILE #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirhcel
force-pushed
the
export-file-env
branch
from
7e9c990
to
f50a021
Compare
SergioGasquez
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Hi! Thanks for the contribution!
I think clap offers a more simple version of doing this by including the env attribute in the args of the export_file as in https://github.com/esp-rs/espflash/blob/main/espflash/src/cli/mod.rs#L62
This also autogenerates the help, eg:
-p, --port <PORT>
Serial port connected to target device
[env: ESPFLASH_PORT=]
f50a021
to
04c3939
Compare
|
You are absolutely right. I tricked myself by just grepping for |
SergioGasquez
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying the location of the export file via the environment variable
ESPUP_EXPORT_FILE. So one does not have to remember to explicitly specify--export-file FILEwhen installling or updating with a custom location of that file.