Support USB-DEVICE on ESP32-S2/S3 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
feature/usb-device
branch
from
9cfa207
to
1080c43
Compare
|
New PACs have been published for the S2/S3. |
|
This works well for me! I guess we just need to figure out what to do with the USB otg library. |
|
(For context, I was having issues getting this working, but I think it's PEBKAC) I think given that @MabezDev got it working it's probably fine to merge, with the exception of the synopsys dependency of course. I'll try to figure out what I've been doing wrong in the meantime. |
bjoernQ
force-pushed
the
feature/usb-device
branch
from
5fe1e99
to
165c803
Compare
jessebraham
changed the title
|
I've re-tested using different hardware and this is now working on both the S2 and S3 for me, using macOS Big Sur (x86_64). |
bjoernQ
force-pushed
the
feature/usb-device
branch
from
165c803
to
cbbbe97
Compare
jessebraham
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
usb-deviceon ESP32-S3 and ESP32-S2The included example was successfully tested on both targets with Windows 11, Windows 10, Ubuntu 2022.10 and MacOS Big Sur.
There might be problems with later MacOS versions which are most likely not related to the driver (but maybe usb-device or usb-serial crate). That needs further investigation but I think this is good to merge, now