Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPI Half Duplex Read HIL test #1782

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Adds a simple HIL test for SPI Half Duplex reads.
It just sets the miso pin high/low and read several bytes to show the spi driver can see the correct value.
The test is rather simple but it's better than no test at all 😄. (I thought of more thorough tests but they'd only work on a subset of the devices supported by the HAL)

I've also written a half duplex write test but it depends on #1765, so I'll open it once it lands.

I skipped the changelog since this is a HIL test

Testing

I ran the HIL test on the real device and the assertion succeed.

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Jul 11, 2024
Merged via the queue into esp-rs:main with commit bb8660d Jul 11, 2024
30 checks passed
@Dominaezzz Dominaezzz deleted the spi_hil branch July 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants