Add HIL tests for all peripherals which are practical to test

[jessebraham]

For now, let's use the table from #809 (comment):

I've gathered a list of the esp-hal modules and how hard/easy I think it would be to test those (take it with a grain of salt as I may have misevaluated some). Also, some modules can't be tested, or it does not make sense:

• aes
  • DMA - AES DMA HIL Tests #1426
  • Non- DMA - Add HIL testing #1297 and Improve AES HIL tests #1423
• analog -
• assist_debug -
• clock -Clock monitor HIL test #1425
• delay - Add Delay HIL test #1415
• ecc - Add HIL test for ECC #1418
• gpio -
• hmac -
• i2c -Adding I2C HIL test #2023
• i2s - Add I2S HIL test #1635
• lcd_cam - Implement async for lcd_cam i8080 #1834
• ledc -
• mcpwm -
• otg_fs -
• parl_io -
• pcnt - Add PCNT HIL test #1746
• rmt -
• rom - Add CRC and MD5 HIL tests #1417
• rsa
  • Blocking HIL RSA tests #1414
  • Async Test and fix async RSA #2002
• rtc_cntl -
• sha - HIL SHA tests #1422
• spi
  • Half duplex -
  • Full duplex
  • DMA
    • Half duplex - Add SPI Half Duplex Read HIL test #1782
    • Full duplex - Add SPI Full Duplex DMA test #1443
• systimer - Fix S2 systimers #1979
• timer -
• trace -
• TWAI HIL test #1912
• uart
  • blocking
  • async
• usb_serial_jtag - Do not reset UsbSerialJtag peripheral #1961

[MabezDev]

One reference for the peripherals is the list @SergioGasquez created here: #809 (comment)

[SergioGasquez]

I will be working on RSA

[SergioGasquez]

I will be working on CRC

[JurajSadel]

Working on usb-serial-jtag

[SergioGasquez]

Working on SHA

[SergioGasquez]

Working on clock monitoring

[JurajSadel]

I'm currently stuck with usb-serial-jtag, I will work on debug-assist next.

[SergioGasquez]

I will also try to add aes_dma and improve the current aes test to cover all the modes.

[Dominaezzz]

I want to write a HIL test for the LCD_CAM but there's not enough loopback pin connections. At the moment there's only two, any chance I could get two more (at least on the S3)?
The alternative is going through the GPIO matrix (which would be ideal I suppose, less faff to run the tests) but that'll need #1662 .

[SergioGasquez]

At the moment there's only two, any chance I could get two more (at least on the S3)?

How many connected pins would you need? Feel free to suggest any pins that you would like to get connected, see #1332 (comment) which might be helpful.

[Dominaezzz]

4 total pairs. A clock pin, a data pin, and two ctrl pins.

According to https://github.com/esp-rs/esp-hal/tree/main/hil-test:

• GPIO2 and GPIO4 are connected.
• GPIO5 and GPIO6 are connected.

I suppose a strategic choice for two more pairs would be:

• GPIO1 and GPIO21. (GPIO1 is the only (excluding strapping pins) pin with the RTC_I2C function).
• GPIO43 and GPIO45. (GPIO43 is U0TXD pin)

My strategy there was to connect a pin with a specific function to another pin with no functions.
This is an S3 only choice, as the LCD_CAM only exists there.

[SergioGasquez]

Awesome, I'll try to get those pins connected in the upcoming days. On the ESP32-S3, the following would be added:

• GPIO1 and GPIO21 are connected.
• GPIO43 and GPIO45 are connected.

[SergioGasquez]

@Dominaezzz, our S3 self-hosted runner already has the connections we discussed.

[jessebraham]

As discussed in our team meeting today, it would be nice to come up with some method of testing the TWAI peripheral, whether this be via loopback, external tranciever, or some other solution.

[bugadani]

We can maybe tick systimer after #1979

[Dominaezzz]

Now that we've got #2128 those extra S3 connections can be removed, as they now get in the way of finding dummy pins. The LCD_CAM HIL test works without the extra connections atm.

[bugadani]

Yeah those are biting me as well on the 32 I think. We probably need some, though, so let's not mindlessly rip off everything :D

[jessebraham]

This is going to be an eternal issue, there will always be new things to test and new devices are released and new use cases/APIs arise, so I am going to close this and we can open individual issues for peripherals as the need arises.