Update and improve esp-lp-hal
#1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jessebraham
force-pushed
the
feature/esp-lp-hal
branch
from
36e98f3
to
3a3321f
Compare
|
On second thought, no reason this can't be reviewed as-is. I will open a subsequent PR implementing |
SergioGasquez
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
LGTM! Just left a few suggestions to follow the same module docs format as we use in esp-hal.
Should we add LP uart, i2c and gpio tests to #1334?
jessebraham
force-pushed
the
feature/esp-lp-hal
branch
from
475b8b5
to
416d7cc
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still some additional work to do (namely implementing
embedded_hal::i2c::I2cand finishing up documentation), but figured I'd get these changes submitted just to try and keep reviewing reasonable.Essentially this PR:
[email protected]by default instead of[email protected]embedded-hal-nbandembedded-iotraits for UARTProgress for #1655.