-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embedded-tests and wiring docs #1652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Weird... all the tests passed on the h2 run but the exit code was still 1 🤔 |
Not all test were executed:
Also, the issue seems to be in probe-rs 0.24.0 for some reason, as if I execute the HIL workflow in esp-rs/main (which does not use the updated embedded-test), it also fails: https://github.com/esp-rs/esp-hal/actions/runs/9347902754/job/25726032013 Locally, I can run the whole test suite on H2 with probe-rs 0.24.0 and embedded-test 0.4.0 |
Trying to update the |
Reverted |
For some reason, in the RPi runners,
While on my local machine
Its worth noticing that we can't use the suggested installation method with sh script as they do not provide armv7 packages Also, the rest of the self-hosted runners are using |
Just used
This also makes the CI fail: https://github.com/esp-rs/esp-hal/actions/runs/9363281580/job/25773867739. Will, install rev Edit: H2 should be back to working state, as |
All the RPi runners but the H2 are running Not sure what to do with this PR, any ideas? Not sure what's wrong with the H2 runner, the tests run fine on my machine with |
c62c904
to
d9d7ad8
Compare
Reverted the |
Opened a probe-rs issue: probe-rs/probe-rs#2546 |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Update probe-rs in our self-hosted-runnersembedded-test
releaseTesting
Triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/9397776874