Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-397: Adds Usage Tab to Metadata Display Entities #398

Merged
merged 16 commits into from
Jan 4, 2024
Merged

ISSUE-397: Adds Usage Tab to Metadata Display Entities #398

merged 16 commits into from
Jan 4, 2024

Commits on Dec 30, 2023

  1. First pass on Usage tab. Not close to be ready yet

    @DiegoPino
    DiegoPino committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    6bdefcd View commit details
    Browse the repository at this point in the history

  2. Adds UUID to the Metadata Display Listing 

    Just a hint for users
    @DiegoPino
    DiegoPino committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    bf5ed0e View commit details
    Browse the repository at this point in the history

  3. Unrelated typo in comment

    @DiegoPino
    DiegoPino committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    fc44078 View commit details
    Browse the repository at this point in the history

  4. Adds AMI set usage 

    in 1.4 we should move (AMI set issue/pull) to using UUIDs for referenced Metadata Displays in AMI sets. Why? Bc we do that since 1.0.0 everywhere, except there. Makes also AMI sets portable between systems.
    @DiegoPino
    DiegoPino committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    4c57fec View commit details
    Browse the repository at this point in the history

  5. Adds View Modes for Nodes now

    @DiegoPino
    DiegoPino committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    38d9196 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. This adds also Exposed Metadata Endpoints (so indirect usage) on View… 

    … Modes

Basically. We calculate first if an exposed view mode uses this template, we remember which ones, then on the View Mode settings we check if also that exposed endpoint is used. And now we remember also the View Mode. Why? For the next pull, where we get now Views/Blocks that Might be also using "rendered" entities and thus, also indirectly via these making use of the template.
    @DiegoPino
    DiegoPino committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    5787384 View commit details
    Browse the repository at this point in the history

  2. Adds Views now. With direct/indirect usage!

    @DiegoPino
    DiegoPino committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    1079304 View commit details
    Browse the repository at this point in the history

  3. Just some comments for me/later. Getting false positives on Views 

    So why? Because Views config save the "overrides" in a different part. Which means if all displays override, the original settings we are getting still have references to the "original usage", e.g a Rendered Entity ... mmmm or an old Field/formatter setting
    @DiegoPino
    DiegoPino committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    40519da View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2024

  1. Better via an Entity Query 

    Still need to figure out Layout Builder settings and when an indirect usage is present
    @DiegoPino
    DiegoPino committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    d4d25ee View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Proper usage in views should be OK now 

    @alliomeria this fixes the issue, my bad
    @DiegoPino
    DiegoPino committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    dc3c234 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Better usage labeling, adds direct/indirect usage column

    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7466e38 View commit details
    Browse the repository at this point in the history

  2. Adds usage as a service, so i don't have to duplicate code somewhere … 

    …else
    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    29eb042 View commit details
    Browse the repository at this point in the history

  3. Uses the service instead of hardcoded logic in the Form

    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5b815f4 View commit details
    Browse the repository at this point in the history

  4. Adds on Metadata Display Listing the actual usage (with .. 

    a shorter calculation logic, returns TRUE on the first encountered usage)
    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d39f2f4 View commit details
    Browse the repository at this point in the history

  5. Small typo/fix

    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6fb6c20 View commit details
    Browse the repository at this point in the history

  6. Another typo. Diego do QA!!!

    @DiegoPino
    DiegoPino committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8749187 View commit details
    Browse the repository at this point in the history