ISSUE-397: Adds Usage Tab to Metadata Display Entities #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
added
enhancement
in 1.4 we should move (AMI set issue/pull) to using UUIDs for referenced Metadata Displays in AMI sets. Why? Bc we do that since 1.0.0 everywhere, except there. Makes also AMI sets portable between systems.
|
Ooo, looking forward to giving this a test run 🤓 Take care and enjoy the rest of your weekend @DiegoPino! |
… Modes Basically. We calculate first if an exposed view mode uses this template, we remember which ones, then on the View Mode settings we check if also that exposed endpoint is used. And now we remember also the View Mode. Why? For the next pull, where we get now Views/Blocks that Might be also using "rendered" entities and thus, also indirectly via these making use of the template.
So why? Because Views config save the "overrides" in a different part. Which means if all displays override, the original settings we are getting still have references to the "original usage", e.g a Rendered Entity ... mmmm or an old Field/formatter setting
Still need to figure out Layout Builder settings and when an indirect usage is present
@alliomeria this fixes the issue, my bad
a shorter calculation logic, returns TRUE on the first encountered usage)
|
@alliomeria this is ready for review. Let me know if you need a walk through, ideas on how to test/break |
|
This is great @DiegoPino! Will be very useful for Archipelago users. Thank you so much! Going to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #397
Just opening the pull even if this is so far just an UI experiment (table? checkboxes? containers? who knows, not super inspired today)
Will keep pushing code until I feel the UI/UX is intuitive