New: disallow identical tests #11
Conversation
There was a problem hiding this comment.
Thanks for the PR! This generally looks good -- I just have a small suggestion.
Also, can you add docs for the rule? There are two places to put docs:
- In a file in the
docs/rules/folder - In the table in the readme here
lib/rules/no-identical-tests.js
Outdated
| docs: { | ||
| description: 'disallow identical tests', | ||
| category: 'Tests', | ||
| recommended: true, |
There was a problem hiding this comment.
Can you set this to false for now? I agree that it would be good to set it to true eventually, but that will be a breaking change, so I think it would be better to set it to false at first and then change it a bit afterwards.
| const cache = Object.create(null); | ||
| // to avoid tests being null | ||
| (tests || []).forEach(test => { | ||
| const testCode = sourceCode.getText(test); |
There was a problem hiding this comment.
Eventually, I think it would also be useful to also catch cases like this:
{
code: 'foo',
options: ['bar']
},
{
options: ['bar'],
code: 'foo'
}But it's probably not necessary to change that as part of this PR.
There was a problem hiding this comment.
yes, it is an enhancement, I will finish it in another PR.:(
lib/rules/no-identical-tests.js
Outdated
| // ---------------------------------------------------------------------- | ||
| // Public | ||
| // ---------------------------------------------------------------------- | ||
| const message = 'This test case should not be identical to someone else.'; |
There was a problem hiding this comment.
Nitpick: Can you reword this message to something like this? "This test case is identical to another case."
docs/rules/no-identical-tests.md
Outdated
| Examples of **incorrect** code for this rule: | ||
|
|
||
| ```js | ||
| /* eslint eslint-plugin/consistent-output: error */ |
There was a problem hiding this comment.
Nitpick: This should say /* eslint eslint-plugin/no-identical-tests: error */
docs/rules/no-identical-tests.md
Outdated
| Examples of **correct** code for this rule: | ||
|
|
||
| ```js | ||
| /* eslint eslint-plugin/consistent-output: error */ |
There was a problem hiding this comment.
Nitpick: This should say /* eslint eslint-plugin/no-identical-tests: error */
aladdin-add
changed the title
|
I'm feeling good. @not-an-aardvark |
fixes #5