-
-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
3dfc4c6
commit ae4c449
Showing
2 changed files
with
117 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/** | ||
* @fileoverview disallow identical tests | ||
* @author 薛定谔的猫<[email protected]> | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const utils = require('../utils'); | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Rule Definition | ||
// ------------------------------------------------------------------------------ | ||
|
||
module.exports = { | ||
meta: { | ||
docs: { | ||
description: 'disallow identical tests', | ||
category: 'Tests', | ||
recommended: true, | ||
}, | ||
fixable: null, // or "code" or "whitespace" | ||
schema: [], | ||
}, | ||
|
||
create (context) { | ||
// ---------------------------------------------------------------------- | ||
// Public | ||
// ---------------------------------------------------------------------- | ||
const message = 'This test case should not be identical to someone else.'; | ||
const sourceCode = context.getSourceCode(); | ||
|
||
return { | ||
Program (ast) { | ||
utils.getTestInfo(context, ast).forEach(testRun => { | ||
[testRun.valid, testRun.invalid].forEach(tests => { | ||
const cache = Object.create(null); | ||
tests.forEach(test => { | ||
const testCode = sourceCode.getText(test); | ||
if (cache[testCode]) { | ||
context.report({ | ||
node: test, | ||
message, | ||
}); | ||
} else { | ||
cache[testCode] = true; | ||
} | ||
}); | ||
}); | ||
}); | ||
}, | ||
}; | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/** | ||
* @fileoverview disallow identical tests | ||
* @author 薛定谔的猫<[email protected]> | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Requirements | ||
// ------------------------------------------------------------------------------ | ||
|
||
const rule = require('../../../lib/rules/no-identical-tests'); | ||
const RuleTester = require('eslint').RuleTester; | ||
|
||
const ERROR = { message: 'This test case should not be identical to someone else.' }; | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Tests | ||
// ------------------------------------------------------------------------------ | ||
|
||
const ruleTester = new RuleTester(); | ||
ruleTester.run('no-identical-tests', rule, { | ||
valid: [ | ||
` | ||
new RuleTester().run('foo', bar, { | ||
valid: [ | ||
{ code: 'foo' }, | ||
{ code: 'bar' } | ||
], | ||
invalid: [] | ||
}); | ||
`, | ||
], | ||
|
||
invalid: [ | ||
{ | ||
code: ` | ||
new RuleTester().run('foo', bar, { | ||
valid: [ | ||
{ code: 'foo' }, | ||
{ code: 'foo' } | ||
], | ||
invalid: [] | ||
}); | ||
`, | ||
errors: [ERROR], | ||
}, | ||
{ | ||
code: ` | ||
new RuleTester().run('foo', bar, { | ||
valid: [ | ||
{ code: 'foo' }, | ||
{ code: 'foo' }, | ||
], | ||
invalid: [ | ||
{ code: 'foo', errors: ['bar'] }, | ||
{ code: 'foo', errors: ['bar'] }, | ||
] | ||
}); | ||
`, | ||
errors: [ERROR, ERROR], | ||
}, | ||
], | ||
}); |