[#27] Provide option for configuration file location #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the change brought in for erlang-ls/erlang_ls#440 via erlang-ls/erlang_ls#445
jfacorro
requested changes
Mar 3, 2020
| @@ -55,6 +55,11 @@ | |||
| "description": | |||
| "Override the default path of the erlang_ls executable with a custom one." | |||
| }, | |||
| "erlang_ls.config.path": { | |||
There was a problem hiding this comment.
All the other names for the configuration values are using camelCase for the names, shouldn't we keep it that way for this configuration as well?
| }, | ||
| initializationOptions: { | ||
| erlang: { | ||
| config_path: workspace.getConfiguration('erlang_ls').get('config.path'), |
There was a problem hiding this comment.
If we use camelCase for configPath this could be workspace.getConfiguration('erlang_ls').configPath, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the change brought in for
erlang-ls/erlang_ls#440
via erlang-ls/erlang_ls#445