Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll : should the server info lens be on or off by default? #601

Closed
alanz opened this issue Mar 20, 2020 · 5 comments
Closed

Poll : should the server info lens be on or off by default? #601

alanz opened this issue Mar 20, 2020 · 5 comments

Comments

@alanz
Copy link
Contributor

alanz commented Mar 20, 2020

We recently landed a code lens to display some information about the erlang_ls server a given file is associated with. This is currently (via #599) set to be off by default, but can be enabled in server config, by

code_lenses:
  - server_info

It puts a single line at the very top of the file saying that erlang_ls is active for the file, and what project root directory is in use for the file. This is especially useful in a multi-project-root environment. The line is clickable, and if clicked a showMessage is sent with more server info, including which erlang_ls.config file has been loaded for this workspace root.

Screenshot 2020-03-20 at 16 50 13

The screenshot shows it in action in emacs, after being clicked on, with the info in the message line at the bottom.

But, we are concerned that having this info displayed at the top of every file may be distracting or otherwise unwelcome, and have thus disabled it by default. It can be enabled via a config file.

But config file loading order is not always clear, as it looks first in the settings (once erlang-ls/vscode#28 lands), then in the project root and failing that in a machine-specific config directory.

One scenario where this lens is useful is identifying which config file is being used for a given project setup.

So, we have a question for users, and ask for votes as follows

  • ❤️ leave it as it is, disabled by default, can be enabled via the config file
  • 👍 make it enabled by default, can be disabled via the config file
  • 💯 some other option, explain in a comment
@robertoaloi
Copy link
Member

robertoaloi commented Mar 20, 2020

Possibly related: microsoft/language-server-protocol#558
The ServerInfo are nowadays also returned by the initialize function.
I proposed to introduce a server-info as part of the actual protocol.

@alanz alanz pinned this issue Mar 21, 2020
@robertoaloi
Copy link
Member

@alanz This issue does not seem to get attention from our users. Did we ever asked the question in the Slack channel?

@alanz
Copy link
Contributor Author

alanz commented Mar 30, 2020

I don't think I did.

@alanz alanz unpinned this issue Apr 8, 2020
@jfacorro
Copy link
Contributor

jfacorro commented May 8, 2020

Should we close this issue?

@robertoaloi
Copy link
Member

I guess so, we can reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants