Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date copy() issue due to default argument for dayOfYear #339

Merged
merged 1 commit into from
May 30, 2023

Conversation

erikc5000
Copy link
Owner

The date copy() methods accepting dayOfYear take precedence over the month/day variants, causing the day to be off by one if the year is changed between a common and leap year. The default value has been removed so that the month/day variant takes precedence, as intended.

@erikc5000 erikc5000 added the bug Something isn't working label May 30, 2023
@erikc5000 erikc5000 merged commit 7b0a9d5 into master May 30, 2023
@erikc5000 erikc5000 deleted the fix-copy-doy branch May 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant