Fix date copy() issue due to default argument for dayOfYear (#339)

erikc5000 · May 30, 2023 · 7b0a9d5 · 7b0a9d5
1 parent d533373
commit 7b0a9d5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/core/src/commonMain/kotlin/io/islandtime/Date.kt b/core/src/commonMain/kotlin/io/islandtime/Date.kt
@@ -294,7 +294,7 @@ class Date(
      */
     fun copy(
         year: Int = this.year,
-        dayOfYear: Int = this.dayOfYear
+        dayOfYear: Int
     ): Date = Date(year, dayOfYear)
 
     companion object {

diff --git a/core/src/commonMain/kotlin/io/islandtime/DateTime.kt b/core/src/commonMain/kotlin/io/islandtime/DateTime.kt
@@ -538,7 +538,7 @@ class DateTime(
      */
     fun copy(
         year: Int = this.year,
-        dayOfYear: Int = this.dayOfYear,
+        dayOfYear: Int,
         hour: Int = this.hour,
         minute: Int = this.minute,
         second: Int = this.second,

diff --git a/core/src/commonMain/kotlin/io/islandtime/OffsetDateTime.kt b/core/src/commonMain/kotlin/io/islandtime/OffsetDateTime.kt
@@ -378,7 +378,7 @@ class OffsetDateTime(
      */
     fun copy(
         year: Int = this.year,
-        dayOfYear: Int = this.dayOfYear,
+        dayOfYear: Int,
         hour: Int = this.hour,
         minute: Int = this.minute,
         second: Int = this.second,

diff --git a/core/src/commonMain/kotlin/io/islandtime/ZonedDateTime.kt b/core/src/commonMain/kotlin/io/islandtime/ZonedDateTime.kt
@@ -351,7 +351,7 @@ class ZonedDateTime private constructor(
      */
     fun copy(
         year: Int = this.year,
-        dayOfYear: Int = this.dayOfYear,
+        dayOfYear: Int,
         hour: Int = this.hour,
         minute: Int = this.minute,
         second: Int = this.second,

diff --git a/core/src/commonTest/kotlin/io/islandtime/DateTest.kt b/core/src/commonTest/kotlin/io/islandtime/DateTest.kt
@@ -40,6 +40,7 @@ class DateTest : AbstractIslandTimeTest() {
     fun `dates can be constructed from year and day of year`() {
         assertEquals(Date(2019, Month.DECEMBER, 1), Date(2019, 335))
         assertEquals(Date(2020, Month.DECEMBER, 1), Date(2020, 336))
+        assertEquals(Date(20200, Month.MARCH, 15), Date(20200, 74))
     }
 
     @Test
@@ -49,6 +50,11 @@ class DateTest : AbstractIslandTimeTest() {
             Date(2018, Month.NOVEMBER, 19).copy(year = 2017)
         )
 
+        assertEquals(
+            Date(20200, Month.MARCH, 15),
+            Date(2020, Month.MARCH, 15).copy(year = 20200)
+        )
+
         assertEquals(
             Date(2018, Month.DECEMBER, 19),
             Date(2018, Month.NOVEMBER, 19).copy(month = Month.DECEMBER)