Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASM build for .NET 9. #28

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add WASM build for .NET 9. #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ jobs:
- '{ "tfm": "net6.0", "emsdk": "2.0.23" }' # eol: 2024-11-12
- '{ "tfm": "net7.0", "emsdk": "3.1.12" }' # eol: 2024-05-14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericsink Have you considered removing unsupported binaries?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Perhaps I should.

But usually "unsupported" != "nobody will complain when it goes away".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yes, always the dilemma.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These assets are particularly painful to keep around because new ones have to be added every release. This is because the emscripten binary format isn't stable and older versions aren't guaranteed to work with newer versions. This is different from iOS and Android where you can just pick a minimum version and live with one binary for years.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're saying that a (purely hypothetical) maintainer who only wants to avoid complaints might actually get MORE complaints by not removing these old files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, eventually once the package size becomes unreasonable, yes.

- '{ "tfm": "net8.0", "emsdk": "3.1.34" }' # eol: 2026-11-14
- '{ "tfm": "net9.0", "emsdk": "3.1.56" }' # eol: 2026-05-12
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -204,6 +205,10 @@ jobs:
with:
name: bin-wasm-net8.0
path: cb/bld/bin
- uses: actions/download-artifact@v4
with:
name: bin-wasm-net9.0
path: cb/bld/bin
# note that the following is mostly a copy of the build script from the SQLitePCL.raw repo
- name: "Set up Java: 11"
uses: actions/setup-java@v1
Expand Down Expand Up @@ -261,6 +266,10 @@ jobs:
with:
name: bin-wasm-net8.0
path: bld/bin
- uses: actions/download-artifact@v4
with:
name: bin-wasm-net9.0
path: bld/bin
- name: Fix permissions
run: |
find ./bld/bin/e_sqlite3 -name *.so | xargs chmod 0775
Expand Down
Loading