Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASM build for .NET 9. #28

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add WASM build for .NET 9. #28

merged 1 commit into from
Aug 28, 2024

Conversation

cincuranet
Copy link
Contributor

No description provided.

@cincuranet
Copy link
Contributor Author

@ericsink Is the failure in SQLitePCLRaw.lib.e_sqlite3.android something that is related to my change?

@ericsink
Copy link
Owner

@cincuranet Probably not. I need to take a closer look, but I've seen similar errors before.

@cincuranet
Copy link
Contributor Author

OK. Let me know if there's anything I can help with.

@ericsink ericsink merged commit 87ab2d9 into ericsink:master Aug 28, 2024
8 of 9 checks passed
@cincuranet cincuranet deleted the wasm9 branch August 28, 2024 16:11
@@ -115,6 +115,7 @@ jobs:
- '{ "tfm": "net6.0", "emsdk": "2.0.23" }' # eol: 2024-11-12
- '{ "tfm": "net7.0", "emsdk": "3.1.12" }' # eol: 2024-05-14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericsink Have you considered removing unsupported binaries?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Perhaps I should.

But usually "unsupported" != "nobody will complain when it goes away".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yes, always the dilemma.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These assets are particularly painful to keep around because new ones have to be added every release. This is because the emscripten binary format isn't stable and older versions aren't guaranteed to work with newer versions. This is different from iOS and Android where you can just pick a minimum version and live with one binary for years.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're saying that a (purely hypothetical) maintainer who only wants to avoid complaints might actually get MORE complaints by not removing these old files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, eventually once the package size becomes unreasonable, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants