Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect PHPUnit version based on series instead of identifier #393

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 3, 2023

This pull request

  • detects the PHPUnit version based on series instead of identifier

Follows #392.
Replaces #387.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7b69bc5) 79.88% compared to head (1d4934f) 75.88%.

Files Patch % Lines
src/Extension.php 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #393      +/-   ##
============================================
- Coverage     79.88%   75.88%   -4.01%     
+ Complexity      116       89      -27     
============================================
  Files            23       21       -2     
  Lines           542      452      -90     
============================================
- Hits            433      343      -90     
  Misses          109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: Michael Voříšek <[email protected]>
@localheinz localheinz changed the title Fix: Simplify Detect PHPUnit version based on series instead of identifier Dec 3, 2023
@localheinz localheinz merged commit 34574df into main Dec 3, 2023
31 of 33 checks passed
@localheinz localheinz deleted the fix/simplify branch December 3, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants