Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract Version #392

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Enhancement: Extract Version #392

merged 1 commit into from
Dec 2, 2023

Conversation

localheinz
Copy link
Member

This pull request

  • extracts Version as a value object

Related to #387.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cb0531b) 74.70% compared to head (ec2ad80) 80.18%.

Files Patch % Lines
src/Extension.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
+ Coverage     74.70%   80.18%   +5.48%     
- Complexity       79      116      +37     
============================================
  Files            19       23       +4     
  Lines           423      540     +117     
============================================
+ Hits            316      433     +117     
  Misses          107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz merged commit 1ecacf8 into main Dec 2, 2023
33 checks passed
@localheinz localheinz deleted the feature/version branch December 2, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants