This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Updates to IGNORE_DEFINITIONS_IN #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 25, 2016 19:46
Pull out the logic into a separate function
Previously, we only looked at the ignored config when finding _defined_ terms. Use the same logic when finding the definition of a term
We had previously required that the beginning and end of an ignored phrase be a word char (to play nicely with \b). This removes that unstated requirement
1) Treating "ignored" text as an exclusion 2) Allowing "ignored" text to begin/end with non-word chars
tadhg-ohiggins
added a commit
that referenced
this pull request
Feb 25, 2016
Updates to IGNORE_DEFINITIONS_IN
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changesets for specifics, but at the high level, this
In service of 18F/atf-eregs#313