Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

All definitions in 555.11 found? #313

Closed
cmc333333 opened this issue Feb 2, 2016 · 21 comments
Closed

All definitions in 555.11 found? #313

cmc333333 opened this issue Feb 2, 2016 · 21 comments
Assignees

Comments

@cmc333333
Copy link
Contributor

Make sure everything that ​_should_​ be a definition is caught. To make this less onerous, we can just focus on the definitions found in the definitions section and make sure that all of those are caught correctly elsewhere in the reg. Look at the definitions section to get your list of definitions, then just search the reg for an occurrence. if any of them work, all of them should work

@cmc333333 cmc333333 added this to the Sprint Gadzooks! milestone Feb 2, 2016
@jehlers
Copy link

jehlers commented Feb 10, 2016

  • Act.
  • Adjudicated as a mental defective.
  • Alien.
  • Ammunition.
  • Appropriate identifying information.
  • Approved storage facility.
  • Articles pyrotechnic.
  • Artificial barricade.
  • ATF.
  • ATF officer.
  • Authority having jurisdiction for fire safety.
  • Barricaded.
  • Blasting agent.
  • Bulk salutes.
  • Bullet-sensitive explosive materials.
  • Bureau.
  • Business premises.
  • Chief, Firearms and Explosives Licensing Center.
  • Committed to a mental institution.
  • Common or contract carrier.
  • Consumer fireworks.
  • Controlled substance.
  • Crime punishable by imprisonment for a term exceeding one year.
  • Customs officer.
  • Dealer.
  • Detonator.
  • Director.
  • Director, Industry Operations.
  • Discharged under dishonorable conditions.
  • Display fireworks.
  • Distribute.
  • Executed under penalties of perjury.
  • Explosive actuated device.
  • Explosive materials.
  • Explosives.
  • Fireworks.
  • Fireworks mixing building.
  • Fireworks nonprocess building.
  • Fireworks plant.
  • Fireworks plant warehouse.
  • Fireworks process building.
  • Fireworks shipping building.
  • Flash powder.
  • Fugitive from justice.
  • Hardwood.
  • Highway.
  • Identification document.
  • Importer.
  • Indictment.
  • Inhabited building.
  • Interstate or foreign commerce.
  • Licensed dealer.
  • Licensed importer.
  • Licensed manufacturer.
  • Licensee.
  • Limited permit.
  • Magazine.
  • Manufacturer.
  • Mass detonation (mass explosion).
  • Mental institution.
  • Natural barricade.
  • Number 8 test blasting cap.
  • Permittee.
  • Person.
  • Plywood.
  • Propellant actuated device.
  • Pyrotechnic compositions.
  • Railway.
  • Region.
  • Renounced U.S. citizenship.
  • Responsible person.
  • Salute.
  • Screen barricade.
  • Softwood.
  • State.
  • State of residence.
  • Theatrical flash powder.
  • Unlawful user of or addicted to any controlled substance.
  • U.S.C.
  • User-limited permit.
  • User permit.
  • Water gels.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Adjudicated as a mental defective"

is not caught here: https://atf-eregs.18f.gov/555-142/2015-25190#555-142-c-2-iii

but is caught here: https://atf-eregs.18f.gov/555-106/2015-25190#555-106-c-4

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Blasting agent" pulls up the wrong definition:

screen shot 2016-02-10 at 4 32 11 pm

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Bullet-sensitive explosive materials" is not used in the reg anywhere else.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Consumer fireworks" and "Display fireworks" are caught within the definition of "Fireworks" because their style is different within the "quotes" but they can't be clicked on:

screen shot 2016-02-10 at 4 45 56 pm

And, clicking on "Consumer Fireworks" brings up the "Fireworks" definition, NOT the "consumer fireworks" definition. Same with "Display fireworks."

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Discharged under dishonorable conditions" is never written that way inside the reg text, all of the search results find this:

screen shot 2016-02-10 at 4 53 30 pm

The definition does mention the U.S. Armed Forces, so it seems like maybe we want to add that phrase?

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Executed under penalties of perjury" is not caught.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Fireworks nonprocess building" is only used in a reg title.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Mass detonation (mass explosion)" also can't tell... strange search results come up for this one.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Mental institution" seems to be part of "committed to a mental institution" every time it appears in the reg.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Number 8 test blasting cap" is not caught because it looks like it is it's own defined term, but the definition is very much a part of "Blasting cap":

screen shot 2016-02-10 at 5 14 59 pm

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Propellant actuated device" ... spelling is hard:

screen shot 2016-02-10 at 5 18 00 pm

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Renounced U.S. citizenship" doesn't seem to show up anywhere other than the definition of it... but also wanted to call out other ways of saying this:

screen shot 2016-02-10 at 5 21 24 pm

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Screen barricade" might be in the footnotes of a table?

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Softwood" is only mentioned when it is defined.

@jehlers
Copy link

jehlers commented Feb 10, 2016

"Water gels" is caught, but it comes up other places in the reg as "water-gels"

screen shot 2016-02-10 at 5 26 38 pm

@jehlers
Copy link

jehlers commented Feb 10, 2016

14 definted terms need to be looked at from this reg.

@cmc333333 cmc333333 self-assigned this Feb 25, 2016
@cmc333333
Copy link
Contributor Author

Adjudicated as a mental defective

555-142/2015-25190#555-142-c-2-ii says "adjudicated a mental defective" (note the missing "as").

@cmc333333
Copy link
Contributor Author

Discharged under dishonorable conditions

We need a case-insensitive match at this point. I'm going to say WONTFIX for now

@cmc333333
Copy link
Contributor Author

Executed under penalties of perjury

All instances are "Executed under the penalties of perjury". Similar WONTFIX for now

@tadhg-ohiggins
Copy link
Contributor

fireworks nonprocess building: used only in a section header.
fireworks plant warehouse: doesn't appear to be used outside the definition.
mass detonation (mass explosion): #413
propellant actuated device: spelling clash, now has its own issue, #412
screen barricade: #414
U.S.C.: we could make this a defined term throughout but it's not clear that would be better.
Perjury and dishonorable discharge are covered in #416 and #415

It appears everything here is fixed or has its own issue now. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants