Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at decreasing logs #1975 #2003

Merged
merged 12 commits into from
Sep 5, 2023

Conversation

petrlicman
Copy link
Collaborator

@petrlicman petrlicman commented Aug 15, 2023

Fixes

This pull request fixes #1975

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@janburak
Copy link
Contributor

In general, the PR uses the startIndex > endIndex check to determine whether a log is decreasing, but a more correct way to do it, whilst also showing intent, is to check whether the log.Direction property is set to Decreasing. Implementing it would require adding the Direction property to Api and Frontend LogObject models. Look at #1826 as an example of working with decreasing logs.

@petrlicman
Copy link
Collaborator Author

Implementation changed in that way that direction property of WitsmlLog is used now instead of comparing Start/End index.

@janburak janburak merged commit 6f0f1d9 into equinor:main Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look at decreasing logs
2 participants