Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-1893 Case insensitive comparison on server urls #1977

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

jaroslavbliznak
Copy link
Contributor

Fixes

This pull request fixes #1893

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janburak
janburak previously approved these changes Aug 1, 2023
Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

Please use topic branches on your fork for future PRs, rather than main, as specified in the fork and pull request workflow which is our contributing process as specified in CONTRIBUTING.MD. This is to avoid including commits from other PRs in your PRs.

@jaroslavbliznak jaroslavbliznak dismissed janburak’s stale review August 1, 2023 07:21

The merge-base changed after approval.

@janburak janburak merged commit 397ffff into equinor:main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case insensitive matching on server urls
2 participants