Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-1979 improve content table sorting #1980

Merged
merged 1 commit into from
Jul 31, 2023
Merged

FIX-1979 improve content table sorting #1980

merged 1 commit into from
Jul 31, 2023

Conversation

janburak
Copy link
Contributor

@janburak janburak commented Jul 30, 2023 •
edited
Loading

Fixes

This pull request fixes #1979

Description

Set default sorting of ContentTable columns to text to make sorting behave as before rework

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

eliasbruvik
eliasbruvik approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janburak janburak merged commit bd369cd into equinor:main Jul 31, 2023
1 check passed
@janburak janburak deleted the FIX-1979 branch July 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve content table sorting
2 participants
@janburak @eliasbruvik