Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dynatrace Installation #1309

Closed
fernandolucchesi opened this issue Oct 13, 2022 · 5 comments
Closed

Improve Dynatrace Installation #1309

fernandolucchesi opened this issue Oct 13, 2022 · 5 comments
Assignees
@fernandolucchesi
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🛠 technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@fernandolucchesi
Copy link
Contributor

fernandolucchesi commented Oct 13, 2022 •
edited
Loading

Move everything to DT PRODUCTION environment / add it to the cookie bot with dtrum.enable()

~

Discuss if needed at all
@fernandolucchesi fernandolucchesi added the 🛠 technical Technical stuffs like reducing debt, refactor or improve code base label Oct 18, 2022
@fernandolucchesi fernandolucchesi mentioned this issue Oct 18, 2022
Closed
fernandolucchesi added a commit that referenced this issue Oct 18, 2022
@fernandolucchesi
🧐 Point DT to prod #1309
bc57797
fernandolucchesi added a commit that referenced this issue Oct 18, 2022
@fernandolucchesi
🐛 Use correct image url #1309
c5ee5ec
fernandolucchesi added a commit that referenced this issue Oct 18, 2022
@fernandolucchesi
♻️ Point preprod to preprod #1309
27e72e7
@fernandolucchesi
Copy link
Contributor Author

Changes were also performed in the internal repo

@fernandolucchesi fernandolucchesi self-assigned this Oct 18, 2022
fernandolucchesi added a commit that referenced this issue Oct 20, 2022
@fernandolucchesi
⚗️ Toggle dynatrace based on cookie consent #1309
f7f88cf
fernandolucchesi added a commit that referenced this issue Oct 20, 2022
@fernandolucchesi
⚗️ Test cookiebot on global-dev #1309
64e844f
fernandolucchesi added a commit that referenced this issue Oct 20, 2022
@fernandolucchesi
✨ Enable cookiebot logic in global dev #1309
5318fdb
@SvSven
Copy link
Contributor

SvSven commented Oct 24, 2022

Left a comment in the code: f7f88cf#comments

fernandolucchesi added a commit that referenced this issue Oct 24, 2022
@fernandolucchesi
✨ Improve cookiebot toggle code #1309
b2db727
@fernandolucchesi
Copy link
Contributor Author

Left a comment in the code: f7f88cf#comments

I like the suggestion! Just refactored =)

fernandolucchesi added a commit that referenced this issue Oct 24, 2022
@fernandolucchesi
⚗️ Try with different syntax #1309
fc7858e
fernandolucchesi added a commit that referenced this issue Oct 24, 2022
@fernandolucchesi
⏪️ Revert to working version #1309
8ab2149
fernandolucchesi added a commit that referenced this issue Nov 1, 2022
@fernandolucchesi
🐛 Check for dynatrace before calling function #1309
3a4bd3d
fernandolucchesi added a commit that referenced this issue Nov 1, 2022
@fernandolucchesi
🐛 Check for dtrum in window object #1309
8564e7c
@fernandolucchesi
Copy link
Contributor Author

Hi @SvSven, this finally seems to be working :) can you please review it one more time?

@SvSven
Copy link
Contributor

SvSven commented Nov 2, 2022

Looks good, it now also doesn't crash anymore with adblock enabled ✅

@SvSven SvSven added the 🚀 ready to deploy Use this if issue is ready to be deployed label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fernandolucchesi fernandolucchesi

Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🛠 technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SvSven @fernandolucchesi