changing exception to warning for diff repcode #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achaikou
reviewed
Mar 18, 2020
achaikou
reviewed
Mar 26, 2020
|
Great! A small note about commit message, and then we should be done: commit title: we usually throw exceptions, but report warnings. Throwing a warning sounds weird. So "Report warning for diff repcode" or "Warn on changed repcode" makes more sense to me. |
When representation code is overwritten in object and not value a warning will be given to users.This situation occurs in actual files. Representation code is overwritten, but looks like value is not important for the users. Hence we set the value to a default one of new type.
achaikou
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing a warning and supplying default value based on the
new reprcode.