Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift restriction 'count (x) isn't 0 and representation code (y) changed, but value is not explicitly set' #192

Closed
achaikou opened this issue Nov 26, 2019 · 2 comments
Closed

Lift restriction 'count (x) isn't 0 and representation code (y) changed, but value is not explicitly set' #192

achaikou opened this issue Nov 26, 2019 · 2 comments
Assignees
@ShikhaMishra9
Labels
good first issue Good for newcomers

Comments

@achaikou
Copy link
Contributor

Found around 15 similar files failing with this error message.
Template just defines the attribute with all the default data. One of the objects overrides reprcode but doesn't bother to provide value. Looks like either value wasn't important for this object, or simply is missing.

We might consider supplying any default value based on the new reprcode.

Current test: test_parse/test_different_repcode_no_value
@ErlendHaa ErlendHaa added the good first issue Good for newcomers label Nov 28, 2019
@ErlendHaa
Copy link
Contributor

Warn not throw

@ShikhaMishra9 ShikhaMishra9 self-assigned this Feb 13, 2020
@ErlendHaa
Copy link
Contributor

Resolved by #248

@achaikou achaikou mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShikhaMishra9 ShikhaMishra9

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErlendHaa @ShikhaMishra9 @achaikou