feat(rpc/v08): add l1_data_gas to v3 transaction resource bounds
#2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial implementation: since we don't _really_ use these new values other than passing those on to the Starknet gateway when submitting new transactions the new field is not added to the `ResourceBounds` type in the common crate. We'll have to do that once these values need to be stored in storage and used in the P2P protocol when adding proper support for Starknet 0.13.4. Closes: #2379
sistemd
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation: since we don't really use these new values other than passing those on to the Starknet gateway when submitting new transactions the new field is not added to the
ResourceBoundstype in the common crate.We'll have to do that once these values need to be stored in storage and used in the P2P protocol when adding proper support for Starknet 0.13.4. I've added issue #2384 as a follow-up for this in the hope that we'll have a clearer picture around the expectations for this new field once we get there.
Closes: #2379