Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-RPC 0.8.0: add l1_data_gas to RESOURCE_BOUNDS_MAPPING #2379

Closed
kkovaacs opened this issue Nov 14, 2024 · 0 comments · Fixed by #2385
Closed

JSON-RPC 0.8.0: add l1_data_gas to RESOURCE_BOUNDS_MAPPING #2379

kkovaacs opened this issue Nov 14, 2024 · 0 comments · Fixed by #2385
Assignees

Comments

@kkovaacs
Copy link
Contributor

Transaction v3 resource bounds mappings should now contain bounds for l1_data_gas in addition to l1_gas and l2_gas. This is something we need to change in the common transaction types as well and also in storage.

How this affects things like transaction hash computation for v3 transactions is not yet known.

@kkovaacs kkovaacs added this to the JSON-RPC 0.8.0 milestone Nov 14, 2024
@kkovaacs kkovaacs self-assigned this Nov 14, 2024
kkovaacs added a commit that referenced this issue Nov 15, 2024
This is a partial implementation: since we don't _really_ use these
new values other than passing those on to the Starknet gateway when
submitting new transactions the new field is not added to the
`ResourceBounds` type in the common crate.

We'll have to do that once these values need to be stored in storage
and used in the P2P protocol when adding proper support for Starknet
0.13.4.

Closes: #2379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant