-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 76: Add weibull distribution to analytic solutions in vignette #93
Issue 76: Add weibull distribution to analytic solutions in vignette #93
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 10 10
Lines 423 423
=======================================
Hits 422 422
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I think we (and I certainly needed this) need some more stepping stones in 3.11. In particular, the target integral in full, why the substitution and then how that allows you to solve.
…gnette' of https://github.com/epinowcast/primarycensoreddist into 76-add-weibull-distribution-to-analytic-solutions-in-vignette
I've done a few more steps as well as describing the basic inspiration. Found a few typos in the intermediate steps as well so good to catch those. |
Looks like it needs a spell check |
/update-wordlist |
/update_wordlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really helpful signposting. Looking forward to implementing this.
Description
This PR adds the Weibull distribution to the analytic solutions currently in "Why it works" vignette, following the same pattern as the Log-Normal and the Gamma.
This PR closes #76 .
Checklist