Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 76: Add weibull distribution to analytic solutions in vignette #93

Merged

Conversation

SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Sep 20, 2024

Description

This PR adds the Weibull distribution to the analytic solutions currently in "Why it works" vignette, following the same pattern as the Log-Normal and the Gamma.

This PR closes #76 .

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@SamuelBrand1 SamuelBrand1 linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (df08644) to head (a4d5a21).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          10       10           
  Lines         423      423           
=======================================
  Hits          422      422           
  Misses          1        1           
Flag Coverage Δ
99.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I think we (and I certainly needed this) need some more stepping stones in 3.11. In particular, the target integral in full, why the substitution and then how that allows you to solve.

@seabbs seabbs enabled auto-merge (squash) September 20, 2024 15:07
@SamuelBrand1
Copy link
Collaborator Author

I've done a few more steps as well as describing the basic inspiration.

Found a few typos in the intermediate steps as well so good to catch those.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs September 20, 2024 15:37
@seabbs
Copy link
Contributor

seabbs commented Sep 20, 2024

Looks like it needs a spell check

@seabbs
Copy link
Contributor

seabbs commented Sep 20, 2024

/update-wordlist

@seabbs
Copy link
Contributor

seabbs commented Sep 20, 2024

/update_wordlist

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really helpful signposting. Looking forward to implementing this.

@seabbs seabbs merged commit 345e95b into main Sep 20, 2024
10 checks passed
@seabbs seabbs deleted the 76-add-weibull-distribution-to-analytic-solutions-in-vignette branch September 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Weibull distribution to analytic solutions in vignette
2 participants