Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement analytical solutions in R and stan #85

Closed
7 tasks done
seabbs opened this issue Sep 18, 2024 · 2 comments · Fixed by #87 or #95
Closed
7 tasks done

Implement analytical solutions in R and stan #85

seabbs opened this issue Sep 18, 2024 · 2 comments · Fixed by #87 or #95
Assignees
Labels
enhancement New feature or request

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 18, 2024

We need

  • R framework to handle cases where we do and don't have analytically solutions + a switch to override and use numerical (for testing/user confidence)
  • Stan framework to handle cases where we do and don't have analytical solutions. This may not need an override switch or we may at least not need to propagate it
  • Implement log version of gamma with uniform
  • Implement log version of lognormal with uniform
  • Make sure all current tests are passing and benchmarks are faster as expected
  • Either add explicit new tests for numerical coverage or make all current tests use the override switch and write new tests to test analytical vs numeric (I think I favour the latter)
  • New benchmarks so we cover both analytical and numeric models.
@seabbs seabbs added the enhancement New feature or request label Sep 18, 2024
@seabbs seabbs self-assigned this Sep 18, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Sep 18, 2024

Work on R side analytical infra is going in here: https://github.com/epinowcast/primarycensoreddist/tree/analytical-infra

using a s3 based approach that dispatches on dist combinations with an override

@seabbs
Copy link
Contributor Author

seabbs commented Sep 20, 2024

Pulling Weibull it its own issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant