-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 85: Add infrastructure for analytical solutions in R #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 99.67% 98.06% -1.62%
==========================================
Files 8 10 +2
Lines 310 362 +52
==========================================
+ Hits 309 355 +46
- Misses 1 7 +6 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f2c5015
to
596c03f
Compare
I'm fairly horrified by what I had to do here to get this working but despite that I think its the most sensible approach that retains modularity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (self-review)
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 596c03f is merged into main:
|
Test gaps are due to the current lack of analytical solutions so I think this is good to go. |
Description
This PR partially closes #85 by adding infrastructure in R for introducing analytical solutions. It also adds skeletons for the current solutions but does not add the analytical solutions themselves.
Checklist