Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Sam writes that we likely want GitHub actions to:
pkgdown
R CMD CHECK
against multiple OS's*lintr
codecov
cmdstanr
code works with the latest version ofcmdstanr
(optional / stretch goal)touchstone
(also a stretch goal / its own issue).*if we have things in our tests we don't expect to run on CRAN then we might also way two versions of this [i.e with and without those tests being skipped]
Also noting that:
epinowcast
and so in the first instance we can mostly just copy them across and read through them to check there is nothing specific toepinowcast
in them.R CMD CHECK
currently we expect those to fail but a focus early in the development should be to get the code base (via cutting and documentation etc) to a place where those both pass. This should really be done ahead of adding in new features, making interface changes, or adding lots of tests in my view. The other critical CI we need in place before adding tests is code coverage as that will help us when building out the testing suite.Changes
So far the changes made have been:
master
anddevelop
branches (we are not using these)I have also written where I think things are completed already in the table above.
In doing so, this PR closes #13.
Checklist