Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 29: Update README workflow #60

Merged
merged 1 commit into from
May 28, 2024
Merged

Issue 29: Update README workflow #60

merged 1 commit into from
May 28, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented May 28, 2024

Description

This PR will close issue #29.

So far, I have copied exactly the file https://github.com/epinowcast/epinowcast/blob/main/.github/workflows/render-readme.yaml from epinowcast to here.

I don't have a very good understanding of these .yaml workflow files yet, so @seabbs if you could give me some guidance on what to change here to get this working, that'd be great. (Happy to have a short call about it if easier!)

Ideally this would serve as a learning opportunity for me to be more confident to make these sorts of edits in future.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works as is to me

@seabbs seabbs marked this pull request as ready for review May 28, 2024 09:43
@seabbs seabbs added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 67bb036 May 28, 2024
3 of 4 checks passed
@seabbs seabbs deleted the readme-workflow branch May 28, 2024 09:44
@athowes athowes mentioned this pull request Jun 12, 2024
9 tasks
seabbs pushed a commit that referenced this pull request Jan 10, 2025
Former-commit-id: d55045cdab4efb2a1a4fddcebfae7d8b841b165e [formerly f074e37f558f78e8d30e129aca4365fedbaff5b6]
Former-commit-id: 04f52ca0202ce04f841003947f936ed4f12636eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants