Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #438: Use class as default for family and reexport common families and formula function #449

Merged
merged 11 commits into from
Nov 19, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Nov 16, 2024

Description

This PR closes #438.

Reexports brms::lognormal, brms::weibull, stats::Gamma and brms::bf.

Changes default to lognormal() away from "lognormal".

I've also altered the test on the recovery of simulated fit_sex parameters to use the right link functions so that they pass. Also on sampling from prior.

I am wondering if lognormal() has different link functions by default than "lognormal". In particular it uses exp() on the SD whereas maybe the string one just uses identity (which would be bad to do, so good we've moved away from it).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes

This comment was marked as outdated.

@athowes athowes requested a review from seabbs November 18, 2024 12:33
@athowes athowes marked this pull request as ready for review November 18, 2024 12:33
@seabbs seabbs force-pushed the revert-family-string-default branch from cad21af to 9c96cb5 Compare November 19, 2024 10:26
@seabbs seabbs enabled auto-merge (squash) November 19, 2024 10:28
@seabbs seabbs merged commit 3991f2f into main Nov 19, 2024
8 checks passed
@seabbs seabbs deleted the revert-family-string-default branch November 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert to using family as family class rather than string
2 participants