Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string in Ebola vignette and pass R CMD CHECK on Windows latest #337

Closed
athowes opened this issue Sep 17, 2024 · 3 comments
Closed

Use string in Ebola vignette and pass R CMD CHECK on Windows latest #337

athowes opened this issue Sep 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 17, 2024

@seabbs for some reason (!?) putting string = "lognormal" causes failure only in the Ebola vignette, and only on Windows latest. Going to make a new issue to resolve this but in the meantime so that we don't have failing tests on main / the rest of the branches I'm in favour of putting this in

Originally posted by @athowes in #334 (comment)

(This is very confusing to me, and hard to debug...)

@athowes athowes added the medium Nice to have for next release label Sep 18, 2024
@athowes
Copy link
Collaborator Author

athowes commented Sep 19, 2024

  • Put print statements
  • Try using a Windows machine
  • Confirm that other string vignettes work: confirmed, yes they do

@seabbs seabbs added high Required for next release and removed medium Nice to have for next release labels Sep 20, 2024
@athowes athowes added the bug Something isn't working label Nov 6, 2024
@athowes
Copy link
Collaborator Author

athowes commented Nov 6, 2024

The error is:

Error: Error: processing vignette 'ebola.Rmd' failed with diagnostics:
missing value where TRUE/FALSE needed

This doesn't really help but nonetheless.

@athowes athowes linked a pull request Nov 7, 2024 that will close this issue
9 tasks
@athowes
Copy link
Collaborator Author

athowes commented Nov 19, 2024

With PR #449 we reverted to using lognormal() hence we no longer have this issue (though we didn't solve it as is).

@athowes athowes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high Required for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants