Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #332: Fix to R CMD CHECK on Windows by reverting family as string in Ebola vignette #334

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Issue #332: Fix to R CMD CHECK on Windows by reverting family as string in Ebola vignette #334

merged 2 commits into from
Sep 17, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Sep 16, 2024

Description

This PR closes #332.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes marked this pull request as ready for review September 17, 2024 10:41
@athowes athowes requested a review from seabbs September 17, 2024 10:42
@athowes
Copy link
Collaborator Author

athowes commented Sep 17, 2024

@seabbs for some reason (!?) putting string = "lognormal" causes failure only in the Ebola vignette, and only on Windows latest. Going to make a new issue to resolve this but in the meantime so that we don't have failing tests on main / the rest of the branches I'm in favour of putting this in

@athowes athowes mentioned this pull request Sep 17, 2024
Closed
@athowes athowes changed the title Issue #332: Fix to R CMD CHECK on Windows Issue #332: Fix to R CMD CHECK on Windows by reverting family as string in Ebola vignette Sep 17, 2024
@seabbs seabbs enabled auto-merge (squash) September 17, 2024 13:00
@seabbs seabbs merged commit a8651e3 into main Sep 17, 2024
7 checks passed
@seabbs seabbs deleted the windows-r-cmd branch September 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CI on Windows latest
2 participants
@athowes @seabbs