Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #432: Remove exported filtering functions #434

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Issue #432: Remove exported filtering functions #434

merged 13 commits into from
Nov 14, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Nov 14, 2024

Description

This PR closes #432.

It moves one filtering function into the two places it's used. And deletes the other which is used no where.

We could have follow up issue on adding back in some better simulation code about this, but we could also do that later.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs November 14, 2024 13:52
@athowes
Copy link
Collaborator Author

athowes commented Nov 14, 2024

@seabbs lmk if you want me to take back over on getting this passing tests

seabbs
seabbs previously approved these changes Nov 14, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay now

@seabbs seabbs merged commit 5934b3b into main Nov 14, 2024
7 checks passed
@seabbs seabbs deleted the remove-filter branch November 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove filter_obs() (if possible)
2 participants