Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filter_obs() (if possible) #432

Closed
athowes opened this issue Nov 13, 2024 · 2 comments · Fixed by #434
Closed

Remove filter_obs() (if possible) #432

athowes opened this issue Nov 13, 2024 · 2 comments · Fixed by #434
Assignees
@athowes
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Nov 13, 2024

Like #431 I think we want to get rid of we can.
@athowes athowes added the high Required for next release label Nov 13, 2024
@athowes athowes self-assigned this Nov 13, 2024
@athowes
Copy link
Collaborator Author

athowes commented Nov 14, 2024

filter_obs_by_obs_time() is just used in the hex sticker and in making simulated data. I think just move it to being sourced there.

@athowes
Copy link
Collaborator Author

athowes commented Nov 14, 2024

filter_obs_by_ptime() is used nowhere. Getting rid.

@athowes athowes mentioned this issue Nov 14, 2024
Merged
9 tasks
seabbs added a commit that referenced this issue Nov 14, 2024
@athowes @seabbs
Issue #432: Remove exported filtering functions (#434)
5934b3b 
* Get rid of filter_obs_by_obs_time

* Remove filter_obs_by_ptime()

* Add filter function to vignettes (missed this due to just looking at .R files)

* Update make_hexsticker.R

* Update approx-inference.Rmd

* Update epidist.Rmd

* Update faq.Rmd

* Update setup.R

* update setup.R in tests

* reformat hexsticker

* style for linting

* Update preprocess.R - fix linting

---------

Co-authored-by: Sam Abbott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athowes athowes

Labels
high Required for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #432: Remove exported filtering functions epinowcast/epidist
1 participant
@athowes