-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #382: Reorganise function locations #389
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 88.55% 90.06% +1.51%
==========================================
Files 11 15 +4
Lines 402 443 +41
==========================================
+ Hits 356 399 +43
+ Misses 46 44 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good
Agree with the points for further issues.
IF we move to the validation model that scoring utils now uses we may be able to side step this discussion (validation .[ methods) |
Agree with the points for further issues.
IF we move to the validation model that scoring utils now uses we may be able to side step this discussion (validating.[ methods). As it stands I think we need to export it |
3627b13
to
264e95f
Compare
Description
This PR will close #382. Creates:
fit.R
stancode.R
validate.R
Removes:
defaults.R
generics.R
I think this is much clearer as a structure.
Follow up issues to create or add comments to existing issues:
epidist_stancode.default
can just pass backNULL
or whatever it is does nothing. Doesn't need to abort.epidist_validate.default
contains the catcher for data without a model class. Could make this error message more informative then?Checklist