Reorganise function locations #382
Assignees
Labels
high
Required for next release
Comments
This was referenced Oct 14, 2024
|
Waiting on #383 to merge before work on this. |
12 tasks
athowes
added a commit
that referenced
this issue
Oct 16, 2024
* Move fitting functions into fit * Create stancode.R * Create validate.R * Remove defaults.R and generics.R and pkgdown groups * Document * Don't need this line * Standardise providing ... argument to generics * Remove whitespace * Fix R CMD CHECK warning * Return NULL by default for stancode * Add test of Stan code NULL case * Add test for stanvars class
seabbs
pushed a commit
that referenced
this issue
Jan 10, 2025
* Move fitting functions into fit * Create stancode.R * Create validate.R * Remove defaults.R and generics.R and pkgdown groups * Document * Don't need this line * Standardise providing ... argument to generics * Remove whitespace * Fix R CMD CHECK warning * Return NULL by default for stancode * Add test of Stan code NULL case * Add test for stanvars class Former-commit-id: 28be50cbb06ff1329877ee99f9606be5f86f06ec [formerly 968138b7e6434efd1eab08a5ae2c8d9a422ef2cd] Former-commit-id: b87df5a3b287b5b2bee9431e5a0fb37e626e0479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment we have functions stored in files like:
generics.Rdefaults.RThese were related to S3 methods.
I think that we should reorganise so that functions are grouped together by functionality rather than by if they are generics or methods. So I'd advocate for moving these out into files like:
formula.Rfamily.Rfit.RTo some extent this has already started to happen (for example there is already
family.R).An auxiliary goal of this is that if we want to add a new model or a new family for an existing model it should be one new script.
As a part of this issue the function groupings on the
pkgdownalso needs to change.The text was updated successfully, but these errors were encountered: