Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 217: Resolve check notes #219

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Issue 217: Resolve check notes #219

merged 5 commits into from
Aug 2, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Aug 1, 2024

Description

This PR closes #217.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes force-pushed the resolve-check-notes branch from 9bcb3af to 41cd1a0 Compare August 2, 2024 09:54
@athowes athowes marked this pull request as ready for review August 2, 2024 11:03
@athowes athowes requested a review from seabbs August 2, 2024 11:03
@athowes
Copy link
Collaborator Author

athowes commented Aug 2, 2024

NOTES left not fixable so that's it I think:

❯ checking for portable file names ... NOTE
  Found the following non-portable file paths:
    epidist/vignettes/approx-inference_cache/html/load-requirements_84057c410b1cb58565e050358d587b14.RData
    epidist/vignettes/approx-inference_cache/html/unnamed-chunk-10_c05e04f0bcd6b4afba009ba5d2b07acf.RData
  
  Tarballs are only required to store paths of up to 100 bytes and cannot
  store those of more than 256 bytes, with restrictions including to 100
  bytes for the final component.
  See section ‘Package structure’ in the ‘Writing R Extensions’ manual.

❯ checking installed package size ... NOTE
    installed size is  7.0Mb
    sub-directories of 1Mb or more:
      doc              3.3Mb
      gadm41_SLE_shp   3.3Mb

❯ checking dependencies in R code ... NOTE
  Unexported objects imported by ':::' calls:
    ‘brms:::dpar_bounds’ ‘brms:::validate_data’ ‘brms:::validate_family’
    ‘brms:::validate_formula’
    See the note in ?`:::` about the use of this operator.

@athowes athowes force-pushed the resolve-check-notes branch from e9ae5e4 to 70b380b Compare August 2, 2024 11:32
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 9d0d677 into main Aug 2, 2024
8 checks passed
@seabbs seabbs deleted the resolve-check-notes branch August 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve possible R CMD CHECK notes
2 participants