Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmdstanr remote dependency #147

Closed
Tracked by #236
athowes opened this issue Jul 11, 2024 · 4 comments · Fixed by #356
Closed
Tracked by #236

Remove cmdstanr remote dependency #147

athowes opened this issue Jul 11, 2024 · 4 comments · Fixed by #356
Labels
high Required for next release infrastructure

Comments

@athowes
Copy link
Collaborator

athowes commented Jul 11, 2024

See #143. Eventually we should try to rely on a stable version of cmdstanr. This would be required for this package to be on CRAN. One way to achieve this is via additional repos argument in DESCRIPTION.
@athowes athowes mentioned this issue Jul 11, 2024
Closed
@seabbs
Copy link
Contributor

seabbs commented Jul 11, 2024

One way to achieve this is via additional repos argument in DESCRIPTION

We can do this now without waiting for it to be on CRAN

@athowes athowes mentioned this issue Aug 9, 2024
Closed
11 tasks
@athowes athowes added the medium Nice to have for next release label Aug 9, 2024
@seabbs seabbs added high Required for next release and removed medium Nice to have for next release labels Sep 20, 2024
@athowes athowes mentioned this issue Oct 1, 2024
Merged
9 tasks
@athowes
Copy link
Collaborator Author

athowes commented Oct 1, 2024

So far I am just trying:

Additional_repositories:
    https://github.com/stan-dev/cmdstanr/releases

Looking through GitHub I didn't find instances of use of Additional_repositories with R universe which is what I had been trying to do before (https://stan-dev.r-universe.dev/cmdstanr).

See r-lib/remotes#618.

@athowes
Copy link
Collaborator Author

athowes commented Oct 1, 2024

The solution (I think) was to use same approach as primarycensoreddist.

Also I am trying to move cmdstanr from Imports to Suggests.

@athowes
Copy link
Collaborator Author

athowes commented Oct 1, 2024

Need to change default away backend = "cmdstanr"

seabbs pushed a commit that referenced this issue Oct 2, 2024
@athowes
Issue #147: Remove cmdstanr from remote (#356)
6ee9839 
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high Required for next release infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #147: Remove cmdstanr from remote epinowcast/epidist
2 participants
@seabbs @athowes