Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on stable package versions rather than remotes #143

Closed
Tracked by #236
athowes opened this issue Jul 10, 2024 · 2 comments
Closed
Tracked by #236

Rely on stable package versions rather than remotes #143

athowes opened this issue Jul 10, 2024 · 2 comments
Labels
high Required for next release infrastructure

Comments

@athowes
Copy link
Collaborator

athowes commented Jul 10, 2024

As a part of the DESCRIPTION we currently rely on GitHub remotes for a number of packages:

Remotes:
    stan-dev/cmdstanr,
    Rdatatable/data.table,
    epinowcast/epinowcast

PR #69 adds brms to this list as there is a bug with the non-HMC inference methods only fixed in the development version of brms (paul-buerkner/brms#1650).

Ideally, we should look to depend on stable package versions. The reasons why are:

When developing R packages, it is generally advisable to avoid depending on GitHub-based dependencies. Instead, using stable versions from CRAN (Comprehensive R Archive Network) is recommended. Here are the reasons why:

  1. CRAN checks packages
  2. CRAN packages are versioned
  3. CRAN provides pre-compiled binaries, making installation easier (faster) for users
  4. GH packages require manual compilation (maybe difficult / requires toolchain?)
  5. CRAN has an archive of package versions, good for reproducibility
  6. GH versions could have breaking changes

I don't know the extent of barriers to doing this. For the brms one it's a matter of time until the fix is on CRAN.

@athowes
Copy link
Collaborator Author

athowes commented Jul 11, 2024

@athowes athowes mentioned this issue Aug 8, 2024
11 tasks
@athowes athowes added the medium Nice to have for next release label Aug 9, 2024
@seabbs seabbs added high Required for next release and removed medium Nice to have for next release labels Sep 20, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 4, 2024

We use stable package versions now.

@athowes athowes closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants