Issue/216 plus 218 fix modal focus #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also see this slack message for clarity on the issues
issue 216
I removed unused and broken code that added an Iframe to the Modal causing a focus flow issue.
Gplus is no longer a social service
Facebook code contained no href
Neither of the above services were visible to the user so I assume they are unrequited.
Please see this ticket #216
issue 218
This fix ensures that the help modal is immediately in focus after the help action button has been clicked
Please see this ticket #218
For both of the above issues
The control flow is now fixed according to manual testing and Silktide.
I have also added a focus flow trap to the modal using JS so that the user explicitly has to close the modal before they can tab any other page elements.