Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus should be on help modal after selection #218

Closed
DanielCouzens opened this issue Aug 5, 2024 · 4 comments
Closed

Focus should be on help modal after selection #218

DanielCouzens opened this issue Aug 5, 2024 · 4 comments
Assignees
@DanielCouzens
Labels
accessibility

Comments

@DanielCouzens
Copy link
Contributor

DanielCouzens commented Aug 5, 2024 •
edited
Loading

Navigation should immediately focus on help modal.

https://docs.google.com/spreadsheets/d/1YS3N5ps9pJGFOxBDi9C2DwA37WQPIVax/edit?gid=154688571#gid=154688571&range=A10:J10
@DanielCouzens DanielCouzens self-assigned this Aug 5, 2024
@DanielCouzens DanielCouzens changed the title Ensure keyboard can be used to navigate modal Focus should be on help modal after selection Aug 7, 2024
@DanielCouzens DanielCouzens mentioned this issue Aug 8, 2024
Merged
@DanielCouzens
Copy link
Contributor Author

I have combined issues 216 and 218 into one PR

please see PR #224

@DanielCouzens
Copy link
Contributor Author

DanielCouzens commented Aug 9, 2024 •
edited
Loading

PR #224 also fixes the following issues from the report

@DanielCouzens
Copy link
Contributor Author

@tomguilbert this is ready to check on the dev instance https://hmlr-dev-pres.epimorphics.net/app/ppd/

@tomguilbert
Copy link

Cool looks good @DanielCouzens and seems to have resolved loads of the issues in one!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielCouzens DanielCouzens

Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomguilbert @DanielCouzens