-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move secondary_opts to opts.R #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we move the function down e.g. to after generation_time_opts()
as the estimate_infections
model is the "primary" one so should come first?
24b823e
to
cad6912
Compare
Done! |
* Move secondary_opts to opts.R * Move sencondary_opts() down
* Move secondary_opts to opts.R * Move sencondary_opts() down
* Move secondary_opts to opts.R * Move sencondary_opts() down
Description
This PR closes #493.
The
secondary_opts()
function was previously defined in theestimate_secondary.R
script. It has now been moved to theopts.R
script where all other_opts*()
related functions live. This will make it easier to find.Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request