Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move secondary_opts to opts.R #570

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Move secondary_opts to opts.R #570

merged 2 commits into from
Feb 26, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #493.

The secondary_opts() function was previously defined in the estimate_secondary.R script. It has now been moved to the opts.R script where all other _opts*() related functions live. This will make it easier to find.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam self-assigned this Feb 21, 2024
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we move the function down e.g. to after generation_time_opts() as the estimate_infections model is the "primary" one so should come first?

@jamesmbaazam
Copy link
Contributor Author

Thanks! Can we move the function down e.g. to after generation_time_opts() as the estimate_infections model is the "primary" one so should come first?

Done!

sbfnk
sbfnk previously approved these changes Feb 22, 2024
@sbfnk sbfnk enabled auto-merge (rebase) February 22, 2024 13:03
@sbfnk sbfnk disabled auto-merge February 22, 2024 13:03
@sbfnk sbfnk enabled auto-merge (squash) February 22, 2024 13:03
@sbfnk sbfnk disabled auto-merge February 26, 2024 07:49
@sbfnk sbfnk merged commit fedc789 into main Feb 26, 2024
11 checks passed
@sbfnk sbfnk deleted the move-sec-opts branch February 26, 2024 07:49
jamesmbaazam added a commit that referenced this pull request Feb 26, 2024
* Move secondary_opts to opts.R

* Move sencondary_opts() down
sbfnk pushed a commit that referenced this pull request May 3, 2024
* Move secondary_opts to opts.R

* Move sencondary_opts() down
sbfnk pushed a commit that referenced this pull request May 3, 2024
* Move secondary_opts to opts.R

* Move sencondary_opts() down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move secondary_opts() to opts.R for findability
2 participants