-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shorten seeding time #413
shorten seeding time #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - needs dev bump and news item.
Do we always increase the version by 1000? I just did but don't actually know why. |
We live in a cargo cult hoping to attract real developers? The idea behind have the dev version be a large number (in the thousands is to make it clear its the dev version. I don't think there is a reason we then need to increment it by a 1000. https://combine-australia.github.io/r-pkg-dev/versioning.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* shorten seeding time * replace example with test * add news item and bump version * Update NEWS.md --------- Co-authored-by: Sam Abbott <[email protected]>
* shorten seeding time * replace example with test * add news item and bump version * Update NEWS.md --------- Co-authored-by: Sam Abbott <[email protected]>
Fixes #409.