Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten seeding time #413

Merged
merged 4 commits into from
Jul 3, 2023
Merged

shorten seeding time #413

merged 4 commits into from
Jul 3, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 3, 2023

Fixes #409.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs dev bump and news item.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 3, 2023

Do we always increase the version by 1000? I just did but don't actually know why.

@seabbs
Copy link
Contributor

seabbs commented Jul 3, 2023

Do we always increase the version by 1000? I just did but don't actually know why?

We live in a cargo cult hoping to attract real developers?

The idea behind have the dev version be a large number (in the thousands is to make it clear its the dev version. I don't think there is a reason we then need to increment it by a 1000.

https://combine-australia.github.io/r-pkg-dev/versioning.html

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit b09c702 into main Jul 3, 2023
@seabbs seabbs deleted the shorter-seed branch July 3, 2023 19:56
NEWS.md Outdated Show resolved Hide resolved
sbfnk added a commit that referenced this pull request Jul 17, 2023
sbfnk added a commit that referenced this pull request May 3, 2024
* shorten seeding time

* replace example with test

* add news item and bump version

* Update NEWS.md

---------

Co-authored-by: Sam Abbott <[email protected]>
sbfnk added a commit that referenced this pull request May 3, 2024
* shorten seeding time

* replace example with test

* add news item and bump version

* Update NEWS.md

---------

Co-authored-by: Sam Abbott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum seeding time too long
2 participants